Fix unsupported credit sale settlement#79
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
payment_method=credit, and the sales backend accepted arbitrary payment method strings because the activeSaleFormonly validatesremark.COMPLETED, deduct inventory, and update member spend/points without recording receivables, deducting balance, or otherwise settling payment.Root cause
accounttobalance; it did not validate values against implementedSale.PAYMENT_METHODS.sale_detailcontained read-time repair logic that wrote sale totals via raw SQL.Fix
account -> balance.mixedbecause that flow has no mixed-settlement handling.other.855.33amount fallback and made invalid totals fail.Validation
mkdir -p logs && .venv/bin/python manage.py test inventory.tests.test_sales_balance_payment inventory.tests.test_sale_status && .venv/bin/python manage.py checkstaticfiles.W004warning for missing/workspace/static.