Fix destructive sales and log audit regressions#78
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
creditpayment method that the backend accepted as a completed sale, decrementing inventory and recording revenue without any receivable or balance deduction.content_type_id=0, causing audit log foreign-key failures; delete could remove the file but report failure with no audit entry.Root cause
Sale.PAYMENT_METHODS.LogEntryrecords used an invalid content type id instead of nullable content type.Fix
account -> balance, remove the unimplemented credit checkout button, and deduct mixed-payment balance portions.LogEntry.content_typefor log file download/delete audit records.Validation
mkdir -p logs && .venv/bin/python manage.py test inventory.tests.test_sales_balance_payment inventory.tests.test_sale_status inventory.tests.test_views.LogFileViewTestmkdir -p logs && .venv/bin/python manage.py test inventory.tests.test_views.BackupViewSecurityTest inventory.tests.test_services.MemberServiceTest.venv/bin/python manage.py checkOnly the existing
staticfiles.W004warning about missing/workspace/staticwas reported.