Fix critical sale integrity and backup restore failures#62
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
payment_method=creditfrom the sale UI could complete a sale, decrement inventory, and update member spend without collecting money or recording receivables.Root cause
Sale.PAYMENT_METHODS, while the template exposed an unimplementedcreditoption.MEDIA_ROOTonly after committing database restore, and failure renders did not supply thebackupcontext expected by the template.Fix
account -> balance, and removed the unimplemented credit button.confirm_restorefield, and supplied restore template context consistently.Validation
python3 manage.py test inventory.tests.test_sales_balance_payment inventory.tests.test_sale_status inventory.tests.test_views.BackupViewSecurityTest inventory.tests.test_services.MemberServiceTeststaticfiles.W004warning for missing/workspace/static.