fix(stats): update chart labels, tooltips, and types - #48
Merged
Conversation
- Rename Cycles per Epoch to PoVW Cycle Composition, update labels - Add tooltips to PoVW Cycle Composition and % Market Cycles charts - Remove redundant PoVW Cycles per Epoch bar chart - Rename Non-Market PoVW Rewards to Total Non-Market PoVW Rewards Per Epoch, add tooltip, add Y-axis labels (ZKC/USD), simplify legend names - Add tooltip to PoVW Reward Rate, add Y-axis labels (ZKC/MHz, USD/MHz), update legend names to ZKC/Mil. Cycles and USD/Mil. Cycles - Convert Miner and Prover Count from AreaChart to LineChart
Preview deployment
The branch alias URL always points to the latest commit on this PR. |
zeroklaw
marked this pull request as ready for review
May 15, 2026 20:10
mintybasil
previously requested changes
May 15, 2026
| type="monotone" | ||
| dataKey="marketCyclesT" | ||
| name="Market Cycles" | ||
| name="Total Market Cycles" |
Member
There was a problem hiding this comment.
Suggested change
| name="Total Market Cycles" | |
| name="Market Cycles" |
| axisLine={false} | ||
| tickLine={false} | ||
| width={60} | ||
| label={{ value: 'ZKC/MHz', angle: -90, position: 'insideLeft', style: { fill: '#9ca3af', fontSize: 10 } }} |
Member
There was a problem hiding this comment.
Suggested change
| label={{ value: 'ZKC/MHz', angle: -90, position: 'insideLeft', style: { fill: '#9ca3af', fontSize: 10 } }} | |
| label={{ value: 'ZKC/Mil. Cycles', angle: -90, position: 'insideLeft', style: { fill: '#9ca3af', fontSize: 10 } }} |
| axisLine={false} | ||
| tickLine={false} | ||
| width={60} | ||
| label={{ value: 'USD/MHz', angle: 90, position: 'insideRight', style: { fill: '#9ca3af', fontSize: 10 } }} |
Member
There was a problem hiding this comment.
Suggested change
| label={{ value: 'USD/MHz', angle: 90, position: 'insideRight', style: { fill: '#9ca3af', fontSize: 10 } }} | |
| label={{ value: 'USD/Mil. Cycles', angle: 90, position: 'insideRight', style: { fill: '#9ca3af', fontSize: 10 } }} |
…names - Revert "Total Market Cycles" → "Market Cycles" and "Total PoVW Cycles" → "PoVW Cycles" for consistency - Change Y-axis labels from "ZKC/MHz" and "USD/MHz" to "ZKC/Mil. Cycles" and "USD/Mil. Cycles" to match legend units - Update tooltip formatter to use "/Mil. Cycles" instead of "/MHz"
Member
Author
|
Pushed a commit addressing all three review suggestions:
|
zeroklaw
dismissed
mintybasil’s stale review
May 15, 2026 20:27
All feedback addressed in commit f4d5b01: legend names reverted, Y-axis labels aligned with Mil. Cycles, tooltip formatter updated. CI green.
mintybasil
pushed a commit
that referenced
this pull request
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Changes
Task 1: PoVW Cycle Composition
Task 2: % Market Cycles per Epoch
Task 3: Removed redundant chart
Task 4: Total Non-Market PoVW Rewards Per Epoch
Task 5: PoVW Reward Rate
Task 6: Miner & Prover Count → Line Chart
Review follow-up (commit f4d5b01)