fix: computePovwRate no longer double-skips the latest completed epoch - #40
Merged
Merged
Conversation
Preview deployment
The branch alias URL always points to the latest commit on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
computePovwRateinsrc/lib/parseEpochs.tsdouble-skips the latest completed epoch. The function usesslice(1, lookback + 1)to "skip the latest epoch" (the ongoing one), but the/api/epochsendpoint already excludes the ongoing epoch — it returns only completed epochs. This meansslice(1)skips the most recent completed epoch instead, which is the most data-relevant point for the PoVW rate calculation.Impact
With 99 completed epochs and a lookback of 10,
computePovwRatewas using epochs 2–11 (sorted desc) instead of epochs 1–10. The most recent completed epoch was always excluded.Fix
Changed
slice(1, lookback + 1)toslice(0, lookback)since the API already handles ongoing-epoch exclusion. Updated comments to reflect the correct behavior.Testing
src/lib/parseEpochs.test.tscovering:lookbacknumber of epochs are usedFixes #35