Fix: overview stats computed over all epochs instead of truncated set - #38
Merged
Merged
Conversation
The overviewStats useMemo was operating on (capped to the last 100 epochs) instead of , causing 'Total Grinding Rewards' and 'Average % Market (All time)' to reflect only the visible 100-epoch window rather than all available data. Also updates the tooltip text from 'last 100 epochs' to 'all available epochs' to match the corrected behavior. Closes #36
Preview deployment
The branch alias URL always points to the latest commit on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: overview stats computed over truncated data instead of all epochs
Closes #36
Problem
In
PovwCycles.tsx, theoverviewStatsuseMemo was operating onmerged(capped to the last 100 epochs via.slice(-100)) instead ofmergedAll. This meant "Total Grinding Rewards" and "Average % Market (All time)" only reflected the 100-epoch window shown on charts, not all available data.Changes
src/components/tabs/PovwCycles.tsx: ChangedoverviewStatsto depend on and compute overmergedAllinstead ofmerged