refactor: use /app/bento-bench as direct Docker entrypoint - #24
Merged
Conversation
- Remove VOLUME for /manifest.json (was never a real volume target) - Remove COPY of docker-run-benchmarks.sh - Set ENTRYPOINT directly to /app/bento-bench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplifies the Docker image by removing the indirection layer:
VOLUME ["/manifest.json"]— manifest is not a volume target, it's passed in at runtime via bind-mount or CMD argCOPY scripts/docker-run-benchmarks.shand delete the scriptENTRYPOINT ["/app/bento-bench"]directly — callers pass args/flags to the binary instead of routing through a shell wrapperWhy
The shell wrapper adds complexity without benefit now that the binary handles its own arg parsing. Direct entrypoint is the right pattern for a CLI benchmark tool.
Diff summary
Dockerfile: removed/manifest.jsonVOLUME, removed script COPY, changed ENTRYPOINTscripts/docker-run-benchmarks.sh: deleted