Spring cleaning - #20
Conversation
mintybasil
changed the title
| "RUNNING" => { | ||
| tokio::time::sleep(tokio::time::Duration::from_millis(100)).await; | ||
| continue; | ||
| tokio::time::sleep(tokio::time::Duration::from_millis(1000)).await; |
There was a problem hiding this comment.
I'd keep this at 100ms. For some shorter proofs this might make the number quite inaccurate, unless the duration is taken from taskdb instead.
There was a problem hiding this comment.
Not a common use case IMO, but precision is definitely a valid concern. Will make this configurable and add a note for users
There was a problem hiding this comment.
Asking for the status every 100ms shouldn't be a problem. If it is, then you have bigger problems. Not sure if it is worth the effort to make it configurable.
There was a problem hiding this comment.
It pollutes debug logs. If extreme precision is required taskdb should be used for timing, in which case the interval does not matter.
| # Build dependencies only — this layer is cached unless Cargo.toml/Cargo.lock changes | ||
| RUN cargo chef cook --release --recipe-path recipe.json | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
This is redundant I think
There was a problem hiding this comment.
Good eye. In this case it's not because the previous COPY . . is into planner which is discarded, not chef.
2 participants
Closes #18, Closes #19.
Additionally: