Skip to content

#577 Rescue PMP type conversion errors with Fbe::Error #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 4 commits into
base: master
Choose a base branch
from
Open

#577 Rescue PMP type conversion errors with Fbe::Error #614

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d56602a
#577: Rescue PMP type conversion errors with Fbe::Error
VasilevNStas Jul 11, 2026
06715b6
#577: Inline msg var per review
VasilevNStas Jul 17, 2026
1e7ab38
#577: Fix Layout/LineLength
VasilevNStas Jul 17, 2026
294f0a5
#577: Fix Elegant/PairedBrackets and Layout/LineLength
VasilevNStas Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions lib/fbe/pmp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def initialize(value, default, type, memo)
define_method(:areas) do
xml.xpath('/pmp/area/@name').map(&:value)
end
others do |*args1|
others do |*args1| # rubocop:disable Metrics/BlockLength
area = args1.first.to_s
node = xml.at_xpath("/pmp/area[@name='#{area}']")
if node.nil?
Expand Down Expand Up @@ -101,20 +101,36 @@ def initialize(value, default, type, memo)
type = prop.at_xpath('type').text
memo = prop.at_xpath('memo').text
default =
case type
when 'int' then Integer(default, 10)
when 'float' then Float(default)
when 'bool' then default == 'true'
else default
begin
case type
when 'int' then Integer(default, 10)
when 'float' then Float(default)
when 'bool' then default == 'true'
else default
end
rescue ArgumentError, TypeError => e
raise(
Fbe::Error,
"Invalid default value '#{default}' for PMP property " \
"'#{param}' in area '#{area}': #{e.message}"
)
end
end
result ||= default
result =
case type
when 'int' then Integer(Float(result).truncate)
when 'float' then Float(result)
when 'bool' then result.to_s == 'true'
else result
begin
case type
when 'int' then Integer(Float(result).truncate)
when 'float' then Float(result)
when 'bool' then result.to_s == 'true'
else result
end
rescue ArgumentError, TypeError => e
raise(
Fbe::Error,
"Invalid value '#{result}' for PMP property " \
"'#{param}' in area '#{area}': #{e.message}"
)
end
pmpv.new(result, default, type, memo)
end
Expand Down
Loading