modules: lvgl: Remove LV_COLOR_16_SWAP option#108497
modules: lvgl: Remove LV_COLOR_16_SWAP option#108497faxe1008 wants to merge 2 commits intozephyrproject-rtos:mainfrom
Conversation
Displays that advertise PIXEL_FORMAT_RGB_565X need LVGL to render RGB565 pixels in byte-swapped order. Treating RGB_565X like native RGB_565 makes non-palindromic colors decode as the wrong hue on the panel. Signed-off-by: Fabian Blatz <fabianblatz@gmail.com> Co-authored-by: Carlo Caione <ccaione@baylibre.com>
| mdac = <0x08>; | ||
| gamma = <0x01>; | ||
| pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>; | ||
| pixel-format = <PANEL_PIXEL_FORMAT_RGB_565X>; |
There was a problem hiding this comment.
No, cause we rely on samples/drivers/display as the reference for colors and orientation.
There was a problem hiding this comment.
Yes that is correct, I fail to understand why thats an issue - shouldn't the sample just deal with the fact that the display now has this default pixel format correctly (assuming that the driver does set the display drivers registeres according to the pixel-format?)
|
cc @carlocaione @JarmouniA |
| height = <132>; | ||
| x-offset = <0>; | ||
| y-offset = <0>; | ||
| pixel-format = <PANEL_PIXEL_FORMAT_RGB_565X>; |
There was a problem hiding this comment.
not all panel controllers have the pixel-format property
display-controller.yaml not lcd-controller.yaml)
There was a problem hiding this comment.
Should have caught now the ones erroring, lets see what CI says.
There was a problem hiding this comment.
yeah, this is the main issue and exactly why I discarded my attempt: I didn't want to deal with all the non-compliant drivers.
faxe1008
force-pushed
the
lv_color_swap16
branch
2 times, most recently
from
1fdd251 to
36a22e5
Compare
Remove usage of LV_COLOR_16_SWAP everywhere. Display drivers support a dedicated RGB_565X format for byte swapping no need to have this additional option. Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
|
3 participants
Since Zephyr and LVGL both now properly support byte-swapped RGB565 there is not point is spraying the LV_COLOR_16_SWAP option everywhere.
Will add a migration guide entry as well.