ci: Added macOS runner#152
Conversation
|
Hi @d3zd3z |
|
|
||
| # Note that Renode is only provided for x86_64 targets. This matches the github runners. | ||
| - name: Install Renode | ||
| if: runner.os == 'ubuntu' |
There was a problem hiding this comment.
This is never true. I believe on ubuntu, the runner.os will be 'Linux'.
There was a problem hiding this comment.
Yes it is Linux. Sorry I didn't catch it myself.
@d3zd3z:Do you know why Renode is added to the workflow? As far as I can see it is not used? We could clean it up?
There was a problem hiding this comment.
I suspect I just copied that from an existing workflow. I think there might have been some goal of renode, but it isn't part of the SDK, just installed in the docker image that Zephyr main uses, which is too large for the free runner github provides.
There was a problem hiding this comment.
@d3zd3z: I can clean it up, if it's ok with you?
I can also leave it in...
| if: runner.os == 'macOS' | ||
| run: | | ||
| # Set hardcoded paths for LLVM 18 installed via Homebrew on macOS 15 - fits with GitHub's macOS 15 image | ||
| echo "LIBCLANG_PATH=/opt/homebrew/Cellar/llvm@18/18.1.8/lib/libclang.dylib" >> $GITHUB_ENV |
There was a problem hiding this comment.
Perhaps something like:
LLVM_PREFIX=/opt/homebrew/opt/llvm/lib
RESOURCE_DIR="$("$LLVM_PREFIX/bin/clang" -print-resource-dir)"
export BINDGEN_EXTRA_CLANG_ARGS="-resource-dir=$RESOURCE_DIR"this should keep it a little less fragile as to specific version.
Any reason to not use macos-26? I build this regularly on Tahoe. And, I haven't needed the int64 override definition below.
There was a problem hiding this comment.
I have now changed it to use macos-26. I cleaned out the int64 override definitions - I apparently need them in my own projects workflow, but they are not needed here.
8897352 to
5dcc6c3
Compare
Added build workflow running on a macOS runner, macos-26. Added env variables to use llvm/clang from homebrew paths. Disable Renode install on the macOS runner (unused?) Moved linux specific commands to a linux specific step. Signed-off-by: Brian Dooleweerdt Rasmussn <brian.rasmussen80@gmail.com>
5dcc6c3 to
87af0cb
Compare
2 participants
Added build workflow running on a macOS runner.
Added env variables to use llvm/clang from homebrew paths. Disable Renode install on the macOS runner (unused?) Moved linux specific commands to a linux specific step.