Fix template command to not print list of deleted files#136
Conversation
For all wrapped Helm commands the list of decrypted files is printed as they get removed at the end of plugin execution. For the `template` command this is undesired, as it means you cannot simply run `helm secrets template` and get valid YAML output. This change suppresses the output of deleted files for the `template` only, meaning it does not alter the behavior of other commands, but just fixes the `template` command to work as I imagine most people would expect it to work. [Fixes issues zendesk#126 and zendesk#132]
|
Can deletion output go to stderr instead? |
|
@dev-kpyc I'd say changes to the delete command's output should probably be a separate PR :) |
|
Bump. Why has this not been approved yet? 👀 |
|
Bump because it's been 5 months since this was pulled. @mateuszzawisza can you help review this 🙏 |
|
Any news? I've used the forked plugin over @jimeh repo and it seems to work fine. What are the blockers? |
|
When you get tired of an issue and go to fix it yourself, only to find that a former teammate of yours has already raised a PR for this 14 months ago that still hasn't been reviewed. 😂 |
|
Hi @kaarolch, you were the last person to merge a PR. Are you available to review this please? |
|
@jimbali Use this fork instead https://github.com/jkroepke/helm-secrets (I'm using this on our production CD for 3 months already, no problem so far) this repo is dead |
5 participants
For all wrapped Helm commands the list of decrypted files is printed as they get removed at the end of plugin execution. For the
templatecommand this is undesired, as it means you cannot simply runhelm secrets templateand get valid YAML output.This change suppresses the output of deleted files for the
templatecommand only, meaning it does not alter the behavior of other commands, but just fixes thetemplatecommand to work as I imagine most people would expect it to work.Fixes issues #126 and #132.