Continued fixups - #20
Merged
Merged
Conversation
Member
Author
|
Ignore that force-push. I accidentally pushed these to master before making the branch. |
ckreibich
approved these changes
Oct 8, 2025
ckreibich
left a comment
Member
There was a problem hiding this comment.
LGTM Tim — as usual I likely won't spot bugs in there. The whole thing is a good reminder to go simple in one's READMEs...
| 'class' => 'table table-bordered' | ||
| ], | ||
| ], | ||
| 'heading_permalink' => [ |
Member
There was a problem hiding this comment.
Maybe add a comment as to what this does?
timwoj
force-pushed
the
topic/timw/continued-fixups
branch
from
October 8, 2025 20:14
cf6542e to
cf533c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix all of the remaining warnings from debug.log from the last few days on the live site.
HeadingPermalinkExtensionto the canonifier to add the anchors to the output, and fix the handling of the anchor links to not result in the debug log.<img>tags in Markdown READMEs like we do for the[]()format for so that we link to the right image files. I noticed this while looking at the JA4 package, which was missing its header image.