Build builtin Spicy analyzers with sanitizers if Zeek uses them#151
Merged
bbannier merged 2 commits intoJun 25, 2026
Conversation
This is a follow-up for zeek/zeek#5561 where we switched to a target-based approach to enable sanitizers. While doing `OBJECT` libraries for builtin Spicy analyzers lost their potentially set sanitizer flags which were previously set globally. Since sanitizers usually do change the implementation of functions and types from the C and C++ standard library this could have lead to false positive errors. With this patch we now enable sanitizer flags for builtin Spicy analyzers if Zeek itself was configured to use sanitizers.
timwoj
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for zeek/zeek#5561 where we switched to a
target-based approach to enable sanitizers. While doing
OBJECTlibraries for builtin Spicy analyzers lost their potentially set
sanitizer flags which were previously set globally. Since sanitizers
usually do change the implementation of functions and types from the C
and C++ standard library this could have lead to false positive errors.
With this patch we now enable sanitizer flags for builtin Spicy
analyzers if Zeek itself was configured to use sanitizers.