Mark unstable tests as failures in JUnit output#136
Merged
timwoj merged 1 commit intoJun 1, 2026
Conversation
bbannier
reviewed
Jun 1, 2026
The JUnit format only has tags for faiulre, error, and skipped. Our unofficial unstable tag causes problems with other tooling that reads the JUnit output, such as CircleCI's test insights.
timwoj
force-pushed
the
topic/timw/mark-unstable-tests-as-failures-in-junit-output
branch
from
8b9d935 to
55ff12c
Compare
bbannier
approved these changes
Jun 1, 2026
timwoj
deleted the
topic/timw/mark-unstable-tests-as-failures-in-junit-output
branch
Contributor
|
Technically this is a breaking change and some users might have actually relied on this. I'm okay hand-wavy saying this will not impact anyone and it was against the spec, but I'm leaving a comment here anyhow. There's no |
Member
Author
|
True, but the documentation for btest also says this:
What we were outputting wasn't valid JUnit XML, and now it's more so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JUnit format only has tags for faiulre, error, and skipped. Our unofficial unstable tag causes problems with other tooling that reads the JUnit output, such as CircleCI's test insights.
This is related to zeek/zeek#5512