Show amounts with the network's currency (ZEC/TAZ/REG)#206
Open
emersonian wants to merge 1 commit into
Open
Conversation
Amounts were always printed as "ZEC" regardless of network. Denominate them with the network's currency unit, matching zcashd's `strCurrencyUnits` (chainparams.cpp): ZEC on mainnet, TAZ on testnet, REG on regtest. `format_zec` now takes a `NetworkType`; a `ticker()` helper maps the network to its unit. Threaded through the `balance`, `list-tx` (including its CSV Symbol and FeeCurrency columns), and `list-unspent` commands and the proposal printer. Inspecting a ZIP 321 payment request is network-agnostic, so it defaults to ZEC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amounts were always printed as "ZEC" regardless of network. This update denominates them with the network's currency unit, matching zcashd's strCurrencyUnits (chainparams.cpp): ZEC on mainnet, TAZ on testnet, REG on regtest.
balance, list-tx, and list-unspent commands now print the correct currency ticker. Inspecting a ZIP 321 payment request is network-agnostic so it defaults to ZEC.