book: Regenerate RPC reference snapshot for z_exportviewingkey (main is red)#656
Open
pacu wants to merge 1 commit into
Open
book: Regenerate RPC reference snapshot for z_exportviewingkey (main is red)#656pacu wants to merge 1 commit into
pacu wants to merge 1 commit into
Conversation
The book_rpc_reference pinning test is failing on main: z_exportviewingkey (added by #461, merged after the #627 branch point) is present in the Rpc trait rustdoc but missing from the committed book/src/rpc/methods.md. #627 generated the snapshot from an earlier main and merged cleanly (different files, no conflict), so the snapshot landed stale and the test now fails on main and on every open PR that merges main (e.g. #631). Regenerated with ZALLET_BLESS=1; the diff is purely the added z_exportviewingkey section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pacu
enabled auto-merge
July 18, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis currently red: thebook_rpc_reference_is_currentpinning test (added in #627) fails becausebook/src/rpc/methods.mdis missing thez_exportviewingkeymethod, which is present in theRpc/WalletRpctrait rustdoc.How it slipped in:
z_exportviewingkeywas added by #461 and merged tomainafter #627's branch point. #627 generated the snapshot from the oldermainand merged cleanly (the two PRs touch different files, so no textual conflict), landing a snapshot that no longer matches the trait. The test therefore fails onmainand on every open PR whose CI mergesmain— e.g. #631, whose tutorial diff doesn't touch any RPC code but still hits this.Fix: regenerated the snapshot with
ZALLET_BLESS=1 cargo test -p zallet-core --test book_rpc_reference. The diff is purely the addedz_exportviewingkeysection — no other method changed.Closes #655.
Test plan
cargo test -p zallet-core --test book_rpc_referencepasses against currentmainNote for maintainers
This is the snapshot analogue of the classic "two PRs, no textual conflict, semantic conflict" gap: a PR adding an RPC method and the snapshot PR can each pass CI independently and merge clean, yet leave
mainred. Prevention options: (a) generatemethods.mdat build time intoOUT_DIRand compare there (no committed artifact to go stale), or (b) require the snapshot regen to accompany any RPC-doc change. Tracked in #655.AI disclosure
Prepared with AI assistance (Claude Opus 4.8, via Claude Code);
Co-Authored-Bymetadata is on the commit. Reviewed by the PR author.🤖 Generated with Claude Code