migrate-zcashd-wallet: import all wallet transactions directly#652
Open
nullcopy wants to merge 1 commit into
Open
migrate-zcashd-wallet: import all wallet transactions directly#652nullcopy wants to merge 1 commit into
nullcopy wants to merge 1 commit into
Conversation
The migration used the wallet's saved transactions only to estimate birthday heights, then dropped all of them from the ZeWIF document unless --buffer-wallet-transactions was given, relying on the post-import chain scan to restore transaction history. That scan only re-derives transactions from the main-chain blocks it scans, so any transaction that was never mined (e.g. a still-unmined send) or was recorded only against a non-main-chain block (a conflicted or reorged transaction) had no on-chain record to recover and was lost. Always carry every transaction through to be imported directly, and remove the now-redundant --buffer-wallet-transactions flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nullcopy
force-pushed
the
feat/migrate-saved-txs
branch
from
July 18, 2026 03:00
42c3738 to
60c7392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration used the wallet's saved transactions only to estimate birthday heights, then dropped all of them from the ZeWIF document unless --buffer-wallet-transactions was given, relying on the post-import chain scan to restore transaction history. That scan only re-derives transactions from the main-chain blocks it scans, so any transaction that was never mined (e.g. a still-unmined send) or was recorded only against a non-main-chain block (a conflicted or reorged transaction) had no on-chain record to recover and was lost.
Always carry every transaction through to be imported directly, and remove the now-redundant --buffer-wallet-transactions flag.
Closes #271
COR-325