Better wallet unlock error handling#641
Open
nullcopy wants to merge 2 commits into
Open
Conversation
nullcopy
force-pushed
the
fix/clear-cached-age-ids
branch
from
July 17, 2026 16:10
024d374 to
1e6cb78
Compare
`age` pulls in `x25519-dalek` with only the `static_secrets` feature, so the `StaticSecret` inside each native age identity was not overwritten in memory when cached identities were dropped during `walletlock` or auto-relock. Depend on `x25519-dalek` directly with the `zeroize` feature so cargo feature unification enables zeroize-on-drop for the single copy in the graph. With this in place, the existing `Vec::clear()` on the identity cache is sufficient to wipe the secrets; no manual clearing is required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ck deadline `KeyStore::unlock` computes an absolute re-lock deadline as `SystemTime::now() + Duration::from_secs(timeout)`, which panics with "overflow when adding duration to SystemTime" for large caller-supplied `timeout` values. Validate `timeout` in the `walletpassphrase` RPC handler and return an `InvalidParameter` error for values that would overflow, so the caller learns to pick a smaller value instead of triggering an internal error. The requested timeout is otherwise honored exactly and remains uncapped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nullcopy
force-pushed
the
fix/clear-cached-age-ids
branch
from
July 18, 2026 03:04
88885a6 to
7ea5c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #467
COR-1594