z_getbalances: split transparent balance into regular and coinbase; z_listunspent: add 'generated' flag

CHANGELOG.md

@@ -16,6 +16,10 @@ be considered breaking changes.
     unified addresses (returning the account's unified full viewing key), and
     an optional `ivk` argument that exports the account's unified incoming
     viewing key instead.
+- `z_listunspent` transparent outputs now include a `generated` field
+  indicating coinbase origin (mirroring `zcashd`'s `listunspent`), so
+  integrators no longer need a `getrawtransaction` round-trip per UTXO to
+  distinguish coinbase from spendable-to-transparent funds.
 
 ### Changed
 
@@ -27,6 +31,15 @@ be considered breaking changes.
 
 ### Fixed
 
+- `z_getbalances` now reports the documented transparent balance split:
+  `regular` contains only non-coinbase funds and `coinbase` is populated with
+  coinbase funds (immature coinbase is reported as `pending` rather than
+  spendable). Previously `regular` silently included coinbase value and
+  `coinbase` was never present.
+- `z_getbalances` account `total` now includes transparent value in its
+  `spendable` and `pending` buckets. Previously only the shielded pools
+  contributed, so a wallet holding only transparent funds reported a zero
+  spendable total.
 - `z_sendmany` and `z_shieldcoinbase` now verify, after building a transaction
   and before broadcasting it, that every transparent output either exactly
   matches a requested payment or has an address that re-derives from the

Cargo.toml

@@ -151,33 +151,28 @@ zip32 = "0.2"
 bip32 = "0.2"
 
 # Zcashd wallet migration
-zewif = { version = "1.0.0-rc.2" }
-zewif-zcashd = { version = "0.1.0-rc.2" }
+zewif = { version = "1.0.0-rc.3" }
+zewif-zcashd = { version = "0.1.0-rc.3" }
 which = "8.0"
 anyhow = "1.0"
 
 # lightwalletd (temporary)
 tonic = "0.14"
 
 [patch.crates-io]
-# Temporary patch for `WalletDb::transactionally_with_extension` (adds atomic
-# z_importkey account+key writes), merged upstream but not yet released. The API
-# lives in zcash_client_sqlite, but the repo is a workspace: pinning only that
-# crate pulls its path-dep siblings from git while their crates.io copies remain,
-# duplicating the librustzcash stack, so the whole stack is pinned to one rev.
-# Replace with the crates.io releases once the next zcash_client_sqlite release
-# ships.
-equihash = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-f4jumble = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_address = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_client_backend = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_client_sqlite = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_encoding = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_keys = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_primitives = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_protocol = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zcash_transparent = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
-zip321 = { git = "https://github.com/zcash/librustzcash.git", rev = "d09d1f390f2e4e3d8978bedfe84dd18aeceef008" }
+# Replace with the crates.io releases once they ship.
+equihash = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+f4jumble = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_address = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_client_backend = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_client_sqlite = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_encoding = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_keys = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_primitives = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_proofs = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_protocol = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zcash_transparent = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
+zip321 = { git = "https://github.com/zcash/librustzcash.git", rev = "f45d49b32392b9aed7ef017047b3995fe5fd6044" }
 
 [profile.release]
 debug = "line-tables-only"