fix(sync): don't shut down the wallet when a transaction data request fails#598
Open
s1ckoleg wants to merge 2 commits into
Open
fix(sync): don't shut down the wallet when a transaction data request fails#598s1ckoleg wants to merge 2 commits into
s1ckoleg wants to merge 2 commits into
Conversation
Servicing errors for GetStatus/Enhancement transaction data requests previously aborted the data-requests sync task, which exits the whole wallet process. A transaction that is reorged away between being requested and being fetched surfaces as a backend error (the zaino backend returns the validator's RPC -5 "No such mempool or main chain transaction" as a ChainIndexError), and because the request is regenerated from the wallet database on every startup, one stale request put the wallet into a permanent crash-loop that ended in systemd start-limit-hit. Log the failure and leave the request for a later sync iteration instead, matching the existing handling of TransactionsInvolvingAddress servicing errors. Wallet database errors still abort as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
s1ckoleg
force-pushed
the
fix-nonfatal-tx-data-requests
branch
from
July 13, 2026 22:40
2b07efa to
ec35e42
Compare
pacu
requested changes
Jul 14, 2026
…equests Per review: invalid data from the chain source is not retryable (it indicates a bug, corruption, or a version mismatch), so it still aborts; Unavailable and Backend errors are logged and retried. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599.
When servicing a
GetStatus/Enhancementtransaction data request fails with a backend error — e.g. the transaction was reorged away and the validator answersRPC -5: No such mempool or main chain transaction— the data-requests sync task exits and takes the whole wallet process down. The request is regenerated from the wallet database on every startup, so one stale request crash-loops the wallet until systemd gives up (start-limit-hit).This change logs the failure and leaves the request for a later sync iteration instead, matching how
TransactionsInvolvingAddressservicing errors are already handled. Once the chain index catches up with the reorg, the request resolves through the existingNone → TxidNotRecognizedpath. Wallet database errors still abort as before.Tested with
cargo check -p zallet-coreandcargo fmt; the failure mode was reproduced live on testnet (v0.1.0-beta.1, zebrad 6.0.0) — details in the linked issue.🤖 Generated with Claude Code