implement textDocument/willSaveWaitUntil#46
Conversation
|
Same motivation as before: zls autofixes |
|
eglot uses a timeout of 0.5s: https://github.com/emacs-mirror/emacs/blob/20edecd21f777848d51b1b892c4ed6192a088fc7/lisp/progmodes/eglot.el#L3037 neovim uses a timeout of 1s: https://github.com/neovim/neovim/blob/5d03060743da195ad2942201eed16708377c1a43/runtime/lua/vim/lsp.lua#L865 I've used a timeout of 1s |
dchinmay2
force-pushed
the
willSaveWaitUntil
branch
from
defe0bd to
4cb7171
Compare
dchinmay2
force-pushed
the
willSaveWaitUntil
branch
from
4520c0a to
a8ec848
Compare
dchinmay2
force-pushed
the
willSaveWaitUntil
branch
from
a8ec848 to
2692077
Compare
|
Hi @p00f , sorry for this sooooo late response, I was too busy recently, and will be busy for months too, so may be it'll take a long time before I responding next time , sorry in advance. I have read your PR and have some questions, I'd added some review comments. Thanks again. |
|
Did you forget to hit send on the review? |
|
I don't think so, but this is the first time I use review in github, so maybe I'm wrong. Couldn't you see these comments?
|
|
you need to press the "finish review" button |
| .stderr(Stdio::piped()) | ||
| .envs(envs) | ||
| .spawn(); | ||
| .current_dir(root_dir) |
There was a problem hiding this comment.
Is setting current dir necessary? If not set, will anything not work properly? or is it just a good coding practice?
There was a problem hiding this comment.
Sorry this is an unrelated change I added to my fork, I did this so that rust-analyzer would pick up overrides correctly (i.e. using nightly rust in projects where I did rustup override set nightly)
There was a problem hiding this comment.
I'll remove this change and put it in a separate PR if you want
There was a problem hiding this comment.
I'll remove this change and put it in a separate PR if you want
Sure, please, thanks.
| (lspce--textDocumentIdenfitier (lspce--uri)) :reason 1)))) | ||
| (lspce--make-willSaveTextDocumentParams)))) | ||
|
|
||
| (defun lspce--request-textDocument/willSaveWaitUntil () |
There was a problem hiding this comment.
IMO, we can make two improvements here. 1. Adding a customizable variable to control whether sending this request or not. 2. Is it better to make this 1 customizable too?
WDYT?
There was a problem hiding this comment.
Sure, I'll add a customizable variable
Yes. I was wrong, haha. Thanks. Can you see the review messages now? |
2 participants
No description provided.