ZEP9 (phase 1): add clarifications for extension naming#330
Conversation
|
@joshmoore - really glad you got this started! 🙌 My feedback is that the PR is hard to review. It touches 15 files, including a ton of minor, unrelated formatting changes to the core spec document. If we want folks to engage and give meaningful feedback, we need to make it easier to review. I'd recommend starting fresh with a minimal PR in which the diffs are reflective exclusively of the actual proposed changes. |
Remaining text blocks are likely to be re-used under the more general "Extension points" section. see: zarr-developers#312
549cc16 to
454faaf
Compare
👍
You're right. I've extracted out #331.
I disagree that they are unrelated. Take a look. The sections I've modified were basically already un-parseable. Since I was adding sections, the outline was getting more convoluted.
👍 Give it a look and let me know what you think. |
|
Thanks for all of your work on this! My current understanding of the practical effect of proposal is as follows: -raw names will be granted fairly easily, e.g. zstd, bfloat16, and others I've proposed would be assigned to me, the ones that zarr-python has started using (string, bytes, vlen-utf8, etc.) would be assigned to someone from zarr-python. URL names will be used only for really experimental stuff, all commonly-used extensions will have raw names since they will be minimal effort. Therefore, the verbosity of the URLs is not really a problem in practice.
The lack of basically any review worries me a bit. But ultimately I'm in favor of this proposal because I think it reflects the reality that the ZEP process isn't working for the existing extension points, and it would be better to just rely on a less formal process. |
I share your concerns to some degree. I think we can adapt the governance structure for extensions in the future, if we think that a more thorough review process would be necessary. We are thinking of forming a zarr specs team that could take on that responsibility. |
jakirkham
left a comment
There was a problem hiding this comment.
Thank you Josh for spearheading this revision! ❤️
Also thanks to everyone on the ZSC who participated in the discussion and early drafts of this work 🙏
Think this provides a good path for developers to explore and expand the use cases Zarr can handle. With the work Norman has done on the first extensions, we can set an example future contributors can follow
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
Thanks, @jakirkham. With that approval, we now have unanimous support from @zarr-developers/steering-council and no major objections since the call on April 3rd. I'll close all remaining comments above (per current GH settings), merge ( Two final points:
|
To clarify, what I mean overall is that we should reserve characters for later potential namespace or unregistered names in lieu of actually specifying that mechanism. That is we should reserve characters. I propose we at least copy the reservations of RFC 3986: Additionally, we should also reserve This would allow us to adopt some kind of URI or namespace mechanism in the future if we so choose. The propsective idea of a default My proposition today is that we reserve |
|
I turned my comment into a pull request on zarr-extensions: |
This PR reduces the scope of ZEP0009 to match the decisions made in zarr-developers/zarr-specs#330 and subsequently published as the 3.1 update of the Zarr specification.
This PR clarifies the extension mechanism concept in the v3 specification. Comments on any changes which will break existing implementations are STRONGLY encouraged. Please see zarr-developers/zeps#65 for background material.
TODOs:
Post-merge: