struct: allow dtype field to be JSON object sans configuration#63
Merged
normanrz merged 2 commits intoJul 14, 2026
Merged
Conversation
normanrz
approved these changes
Jul 14, 2026
Contributor
Author
|
it might be nice to make these changes a bit more auditable -- should we add a revision history to the spec document? |
Member
|
Feel free to add that to the struct readme. |
Assisted-by: ClaudeCode:claude-fable-5
Contributor
Author
done |
normanrz
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the schema permit data types declared in the object-with-no-configuration form, e.g.
{"name": "float64"}. Verbose but permitted by the spec.We can minimize changes like this by settling on reusable JSON schemas for the Zarr v3 spec (xref zarr-developers/zarr-specs#347)