Support for HTTP clients#1084
Open
TwentyPast4 wants to merge 42 commits into
Open
Conversation
* added comparison operator for uri
…loak-in-jackpot-server-and-client feat(jackpot): Support keycloak in jackpot server and client (SW-1007)
…s (SW-5612) * Replace the single-pass chunked decoder that ended after the first chunk and mishandled framing bytes split across socket reads. * Buffer incoming data and decode complete chunks incrementally, retaining partial chunk-size lines and inter-chunk CRLFs until the next read; finish only on the terminal zero-length chunk. * Make response::on_parsing_completed idempotent and gate completion on body_ready() so chunked bodies are not closed prematurely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going over the available library options, I noticed there's no good pick for having both HTTP and WS in both client and server roles, which were developed to a point where it would be nice to use. I guess boost beast was closest.
Websocketpp is great - and written such that I could relatively easily add HTTP client support to it.
That said, this implementation is not perfect and was tailored to my specific use cases, so the PR might include other changes which might not be directly related or desired. I'm opening the PR for the purpose of presenting a working example on how it could be done and to signal the need for such a feature. Feel free to suggest changes in written form or commit form here or the source repo respectively.