chore: trim residual ceremony from coverage chain#22
Merged
Conversation
Three small follow-ups in the spirit of the prebuild:packages cleanup in a7e9fc3, surfaced by surveying what was left after PR #21: 1. .github/workflows/ci.yml coverage job: dropped the explicit `pnpm prebuild:packages` step. `pnpm coverage:check` (and coverage:summary) both invoke `turbo run test:coverage`, which declares `dependsOn: ["^build"]` in turbo.json — Turbo handles package prebuild automatically. Same reasoning as a7e9fc3. 2. package.json: composed `coverage:check` from `coverage:summary` instead of duplicating its prefix. After 00b37f6 made coverage:check self-sufficient, the two scripts shared an identical `turbo run test:coverage --filter=!@zapengine/mobile && tsx scripts/coverage-summary.ts` prefix. Now it's: coverage:check = coverage:summary + regression gate. 3. turbo.json: deleted the `test:coverage:check` task definition — verified by repo-wide grep that nothing invokes it (not in any package.json, not in any workflow, not in any doc). Vestigial. The actual regression gate is composed at the package.json script level, not as a Turbo task. Verified locally: - rm -rf packages/*/dist + pnpm turbo run test:coverage on packages with no DB needs → 3 successful, packages auto-built via ^build - pnpm exec tsx scripts/coverage-summary.ts → aggregates correctly - pnpm lint:repo → drift checks green - prettier --check on all 3 files → clean https://claude.ai/code/session_01VCU2uisRq7X58rrnWA2Ckd
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small follow-ups in the spirit of the
prebuild:packagescleanup that landed in #21 (commit a7e9fc3), surfaced by surveying what was left after that PR merged.Changes
pnpm prebuild:packagesstep from the CIcoveragejob.github/workflows/ci.ymlcoverage:checkfromcoverage:summaryinstead of duplicating the prefixpackage.jsontest:coverage:checkTurbo taskturbo.jsonTotal: -9 LOC, behavior unchanged.
Why
1. CI coverage job prebuild
pnpm coverage:check(baseline path) andpnpm coverage:summary(no-baseline path) both invoketurbo run test:coverage --filter=!@zapengine/mobile. Thetest:coveragetask inturbo.jsondeclaresdependsOn: ["^build"], so Turbo auto-builds internal packages before the test run. Explicitprebuild:packagesis duplicate work — exactly the same reasoning that justified removing it fromcheck:local/check:ci/check:ci:corein #21.2. Compose
coverage:checkAfter #21 made
coverage:checkself-sufficient (it now runstest:coverageitself), the two scripts shared an identicalturbo run test:coverage --filter=!@zapengine/mobile && tsx scripts/coverage-summary.tsprefix. Now:Single source of truth for the test+summary behavior; the relationship between the two scripts is explicit.
3. Delete
test:coverage:checkVerified via repo-wide grep — defined in
turbo.jsonbut never invoked anywhere (nopackage.jsonscript, no CI step, no docs). Vestigial from an earlier iteration. The actual regression gate is composed at the package.json script level, not as a Turbo task.Verification
rm -rf packages/*/dist && pnpm turbo run test:coverage --filter=@zapengine/intent-engine --filter=@zapengine/types→ 3/3 successful (packages auto-rebuilt via^build)pnpm exec tsx scripts/coverage-summary.ts→ aggregates correctlygrep -rn "test:coverage:check"→ 0 matches in repopnpm lint:repo→ drift checks greenprettier --checkon all 3 files → cleanNo business logic changes; just config trimming.
https://claude.ai/code/session_01VCU2uisRq7X58rrnWA2Ckd
Generated by Claude Code