refactor: restructure engine, deduplicate OOB/Options/SDK logic#216
Open
wqnmlgb151 wants to merge 5 commits into
Open
refactor: restructure engine, deduplicate OOB/Options/SDK logic#216wqnmlgb151 wants to merge 5 commits into
wqnmlgb151 wants to merge 5 commits into
Conversation
wqnmlgb151
commented
Jun 10, 2026
- Split engine.go (2045→878 lines) into 7 focused files: webprobe, pedm, stage_fingerprint, filter, oob_coordinator, context, errors
- Unify OOB token detection (ContainsOOBToken/PocUsesOOB exported)
- Extract IsNetOnly() method on poc.Poc
- Add RunnerOption pattern (WithSDKMode), delete createSDKRunner
- Add sendOrDrop[T] generic channel helper, integrated at 6 call sites
- Add Options.ApplyDefaults/ValidateRateLimitModes/TargetStrings helpers
- Extract ScanContext for runtime callback separation
- Delete MMutex, collectOrderedPocPaths, ~300 lines commented-out dead code
- Fix ReadComplieOptions typo → ReadCompileOptions
- Add 43 test cases across filter, context, poc, oob_coordinator, fingerprint
- Add ProgressRenderer + GracefulShutdown types (pending main.go integration)
- gofmt all files
- Split engine.go (2045→878 lines) into 7 focused files: webprobe, pedm, stage_fingerprint, filter, oob_coordinator, context, errors - Unify OOB token detection (ContainsOOBToken/PocUsesOOB exported) - Extract IsNetOnly() method on poc.Poc - Add RunnerOption pattern (WithSDKMode), delete createSDKRunner - Add sendOrDrop[T] generic channel helper, integrated at 6 call sites - Add Options.ApplyDefaults/ValidateRateLimitModes/TargetStrings helpers - Extract ScanContext for runtime callback separation - Delete MMutex, collectOrderedPocPaths, ~300 lines commented-out dead code - Fix ReadComplieOptions typo → ReadCompileOptions - Add 43 test cases across filter, context, poc, oob_coordinator, fingerprint - Add ProgressRenderer + GracefulShutdown types (pending main.go integration) - gofmt all files
Owner
|
这次改动范围较大,想确认一下是否已经做过充分的测试?另外,能否请您补充一下改动的动机,以及改动前后的主要区别? |
Author
|
改动已经过充分测试:
改动动机:原 改动前后主要区别:
|
Delete 28 lines of commented-out regex functions in celprogram.go, run gofmt across the entire repo, and add .editorconfig to prevent future formatting drift. No behavior change.
Author
🔧 Code Cleanup UpdateThis is a follow-up to address code quality issues identified in review: Changes in this update:
Verification:Files changed:
No behavior changes. All changes are purely cosmetic/formatting. |
…uidance Add detailed scan flow, key packages table, PoC execution model, refactoring notes from 4 rounds of engine splits, code style rules, and common pitfalls for Windows Go development.
…rkflow guidance" This reverts commit 7e89bc4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.