refactor(network): align header range records internally#309
Merged
Conversation
Bind each delivered header to its size and roots immediately after v7 decode so internal trimming and buffering cannot misalign per-height data.
|
Note Complete: Audit complete. V12 did not find any issues that need review. Open the full results here. Analyzed 10 files, diff |
evan-forbes
approved these changes
Jul 20, 2026
evan-forbes
added
headersync
Make each aligned record carry its authoritative height so trimming and root validation preserve exact per-height identity without a separate range source of truth.
Use the conventional InvalidRange name now that checked range construction makes the rejected condition clear at each call site.
p0mvn
marked this pull request as ready for review
July 21, 2026 00:47
Collaborator
Author
|
@cursor review |
p0mvn
removed
the
network breaking
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3534566. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Header-sync responses still cross internal async boundaries as separate header, body-size, and root vectors after v7 decoding. Keeping those vectors independent makes trimming and buffering vulnerable to per-height misalignment even though the wire payload has already been validated.
Solution
HeaderRangeEntryto bind one header to its body-size hint and optional rootsHeaderRangePayloadHeaderSyncWireRequestIdentitythroughWireHeadersHeaderSyncMessage, the v7 byte layout, and stream version unchangedTesting
cargo fmt --allcargo test -p zakura-network --lib zakura::header_sync(165 passed)cargo clippy -p zakura-network --lib --tests -- -D warningsSpecifications & References
Follow-up Work
A stacked v8 PR will make correlated wire messages self-contained and serialize aligned entries atomically.