revert(zcashd): remove pruned block request diagnostics#303
Closed
p0mvn wants to merge 1 commit into
Closed
Conversation
This reverts commit ac7d8c0.
|
Note Complete: Audit complete. No review-worthy issues remain after automatic triage. One finding was auto-invalidated. Open the full results here. Analyzed three files, diff |
p0mvn
marked this pull request as ready for review
July 20, 2026 17:37
p0mvn
marked this pull request as draft
July 20, 2026 17:41
ebfull
marked this pull request as ready for review
July 20, 2026 18:07
ebfull
marked this pull request as draft
July 20, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Revert ac7d8c0 (
fix(zcashd): diagnose requests for pruned blocks (#279)).Solution
Remove the zcashd-compat pruning-retention wiring, canonical-header diagnostic lookup, rate-limited error logging, and their dedicated tests. Requests for unavailable block bodies return the existing
notfoundresponse without the additional diagnostic state query.Testing
cargo fmt --all -- --checkcargo test -p zakura components::inbound::tests(17 passed)cargo clippy -p zakura --all-targets -- -D warningsSpecifications & References