Use dismad's suggested better RPC error#301
Merged
Merged
Conversation
|
Note Complete: Audit complete. V12 did not find any issues that need review. Open the full results here. Analyzed one file, diff |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_fdd7f64a-9dd1-410e-9084-5c54fa69ef75) |
evan-forbes
approved these changes
Jul 20, 2026
|
Thank you! |
czarcas7ic
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in Dismad's error message improvement from upstream
Note
Low Risk
Message-only change for an existing error path; no logic, codes, or API shape changes.
Overview
Updates the
getrawtransactionRPC error when a txid is missing from both the mempool and chain state.The user-facing message changes from "No such mempool or main chain transaction" to "Transaction not found in mempool or best chain", aligning with an upstream wording improvement. The legacy error code (-5,
InvalidAddressOrKey) is unchanged.Snapshot tests for unknown txids on mainnet and testnet are updated to expect the new message.
Reviewed by Cursor Bugbot for commit c019787. Bugbot is set up for automated code reviews on this repo. Configure here.