fix(health): bound active HTTP connections#219
Draft
ValarDragon wants to merge 1 commit into
Draft
Conversation
|
Note Complete: Audit complete. No review-worthy issues remain after automatic triage. Two findings were auto-invalidated. Open the full results here. Analyzed two files, diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The health listener accepted connections based only on a per-interval counter.
Each accepted socket spawned a detached Hyper task with no active-connection
limit or request timeout, so clients could keep accepted sockets open while the
counter reset and later connections created additional tasks.
Fix
The accept loop now acquires an owned semaphore permit before spawning a
connection task. Connections beyond the active limit are dropped immediately,
and the permit is held until Hyper finishes or the connection-wide request
timeout expires. HTTP/1 keep-alive is disabled because the health API only
serves lightweight probe requests.
The existing accept-rate counter remains as a burst limit, with its interval
reset applied before the next connection is counted.
Validation
cargo test -p zakura components::healthcargo fmt --all -- --checkcargo clippy -p zakura --lib -- -D warningsThe targeted suite includes new tests proving that idle sockets are closed and
that connections above the active limit cannot receive a health response.