Fix code review bugs and translation errors#5
Merged
Conversation
Bug fixes: - fix m_startupSyncDone set before async download completed, causing notifications for all existing messages on every daemon start - fix deleteMessages API misuse: user-initiated deletes no longer hit update_highest_message.json, which reset the server high-water mark backward and caused re-delivery of old messages - fix m_pendingDeleteIds race in batch deletes (member removed entirely) - fix notification tracking maps never cleaned on dismiss/expiry by connecting to NotificationClosed D-Bus signal (memory leak) - zero WebSocketManager secret/deviceId on disconnect Refactors: - MessageStore: add QSet index for O(1) containsMessage (was O(n) per call, O(n^2) per sync); simplify markAllAsRead; remove dead code - SailPushClient: extract sendRequest/emitError/extractErrorMessage helpers, Action enum replaces string-based dispatch - WebSocketManager: extract handleFrame from duplicated text/binary handlers; parseFrame returns int instead of QVariant - DbusInterface: extract runSystemctl helper - Daemon: extract isUiRunning and pollingIntervalFromIndex helpers, inline handleEmergencyMessage, skip redundant emergency notification - NotificationManager: rewrite stripHtml to single-pass globalMatch - share pending_open path via new constants.h (inline constexpr) Cleanup: - remove dead userKey/deviceName from credential interface (saved but never read back); remove dead m_userAgent member, unreadMessages, highestMessageId, maxMessages - cache locale.name() in loadTranslations; dedup sound download queue Translations: - add missing LoginHelper string to all 39 .ts files (was absent after code added post-lupdate) - fix errors: hr (prije typo), bs (nominative case x2), lv (leading space), be (adjective gender), is (afrita->dulrada, word order), hy (question mark), ka (deleting vs delete disambiguation) Tests: 7/7 passing. Net -97 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs found in code review and corrects translation errors across 39 languages.
Bugs
Refactors
Cleanup
Translations
Tests
7/7 passing. Net -97 lines.