Skip to content

Avoid redundant grid_ref in exportScrollback spacer check #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackslash merged 1 commit into from
Jul 18, 2026
Merged

Avoid redundant grid_ref in exportScrollback spacer check #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ghosttyvt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,10 @@ QByteArray GhosttyVt::exportScrollback(uint16_t &outCols, uint16_t &outRows) con

// Skip wide character spacer cells — they have no text content
// but would otherwise be exported as phantom spaces.
if (isWideCharSpacer(m_terminal, col, static_cast<uint32_t>(row)))
// Reuse the grid ref above instead of isWideCharSpacer()'s second grid_ref.
GhosttyCell cell = 0;
if (ghostty_grid_ref_cell(&ref, &cell) == GHOSTTY_SUCCESS
&& isWideSpacerCell(cell))
continue;

size_t graphemeLen = 0;
Expand Down
Loading