Skip to content

fix(config): move dts configuration to baseConfig for better maintainability#233

Merged
z0ffy merged 1 commit intomainfrom
feature/dts
Jul 10, 2025
Merged

fix(config): move dts configuration to baseConfig for better maintainability#233
z0ffy merged 1 commit intomainfrom
feature/dts

Conversation

@z0ffy
Copy link
Copy Markdown
Owner

@z0ffy z0ffy commented Jul 10, 2025

Summary by Sourcery

Enhancements:

  • Centralize the dts configuration in baseConfig to improve maintainability and remove duplication.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 10, 2025

Reviewer's Guide

This PR centralizes the TypeScript declaration file (dts) settings by moving the configuration into the shared baseConfig, removing duplication and improving maintainability.

Class diagram for tsup configuration refactor

classDiagram
    class baseConfig {
        +boolean sourcemap
        +boolean clean
        +boolean minify
        +object dts
        +function esbuildOptions(options)
    }
    class dts {
        +string entry
        +boolean resolve
    }
    baseConfig --> dts : contains
    class CJSConfig {
        <<extends baseConfig>>
        +object define
    }
    CJSConfig --|> baseConfig : extends
Loading

File-Level Changes

Change Details Files
Centralize dts configuration into baseConfig
  • Added dts entry and resolve options to baseConfig
  • Removed duplicate dts section from the cjs build configuration
tsup.config.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @z0ffy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@z0ffy z0ffy merged commit baa8e0b into main Jul 10, 2025
4 checks passed
@z0ffy z0ffy deleted the feature/dts branch July 10, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant