refactor(setup): split setup engine into phases - #1283
Open
cedric013 wants to merge 2 commits into
Open
Conversation
cedric013
force-pushed
the
refactor/1276-setup-engine-phases
branch
from
July 27, 2026 12:09
389115f to
4597129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_setup_with_optionsinto smaller phase helpers.Closes #1276
Validation
rustfmt --check src/setup/with_options.rsgit diff --checkcargo check --libwas started but exceeded the useful local window and was cancelled before completion.