Skip to content

fix(addons): scrub memento source env for stdio - #1251

Merged
yvgude merged 1 commit into
yvgude:mainfrom
cedric013:fix/1250-mcp-secret-memento-env-scrub
Jul 27, 2026
Merged

fix(addons): scrub memento source env for stdio#1251
yvgude merged 1 commit into
yvgude:mainfrom
cedric013:fix/1250-mcp-secret-memento-env-scrub

Conversation

@cedric013

Copy link
Copy Markdown
Contributor

Summary

  • remove LEAN_CTX_SECRET_* fallback variables from stdio child environments
  • preserve explicitly restored secret_env target values after source cleanup
  • add regression coverage for legacy stdio env inheritance

Tests

  • CARGO_TARGET_DIR=/tmp/lean-ctx-pr-1250-target cargo test --lib core::addons::env_scrub::tests -- --nocapture
  • rustfmt --edition 2024 --check src/core/addons/env_scrub.rs
  • git diff --check -- rust/src/core/addons/env_scrub.rs

Fixes #1250

@yvgude
yvgude merged commit fb0251d into yvgude:main Jul 27, 2026
25 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent secret memento fallback env from leaking to stdio children

2 participants