Skip to content

Fix #16: Focusing on "or explore first!" doesn't move the background to it#21

Draft
mmaismma wants to merge 1 commit into
mainfrom
GH-16
Draft

Fix #16: Focusing on "or explore first!" doesn't move the background to it#21
mmaismma wants to merge 1 commit into
mainfrom
GH-16

Conversation

@mmaismma

Copy link
Copy Markdown
Member

Removed the conditional check for isHoverWanted.matches in onFocus & onBlur event handlers.

-    onFocus={e => isHoverWanted.matches && setHighlightedAction(e.currentTarget)}
-    onBlur={_ => isHoverWanted.matches && setHighlightedAction(primaryActionRef.current)}
+    onFocus={e => setHighlightedAction(e.currentTarget)}
+    onBlur={_ => setHighlightedAction(primaryActionRef.current)}

Fixes #16.

@mmaismma mmaismma requested a review from Techkulkul April 14, 2025 20:47
@mmaismma mmaismma self-assigned this Apr 14, 2025
@mmaismma

Copy link
Copy Markdown
Member Author

Noticed a problem with this fix: it doesn't work with touch devices (or devices with reduced motion enabled for the matter).

Desktop (has hover):

Screencast_20250415_023121.mp4

Mobile (no hover):

Screencast_20250415_023152.mp4

@mmaismma mmaismma marked this pull request as draft April 14, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focusing on "or explore first!" doesn't move the background to it

1 participant