Add rails 8.1 tests and fix warning about ActiveSupport::Configurable#100
Merged
Conversation
nudded
force-pushed
the
fix-rails-8.1-compat
branch
5 times, most recently
from
553dba8 to
e8c2ade
Compare
Contributor
Author
|
@yuki24 any thoughts? |
Owner
|
@nudded Apologies for the delay. The CI builds are very old and I had to make a relatively larger change to that. Would you mind rebasing? The CI builds should run for your PR as well. |
nudded
force-pushed
the
fix-rails-8.1-compat
branch
from
e8c2ade to
40d2f45
Compare
Contributor
Author
|
@yuki24 rebased, thanks! |
Owner
|
@nudded Thanks! |
Contributor
Author
|
@yuki24 do you want to release this version, I suppose rails 8.2 is right around the corner? |
Owner
|
@nudded a bit too busy these days to work on open source honestly, but I will try to find time to do this this weekend. Apologies for the long delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
ActiveSupport::Configurablewill be deprecated in Rails 8.2. I've replaced it based on the recommendation to useclass_attributeAs a bonus I've fixed the specs by adding ruby-concurrent as a dependency in the gemfile. see: rails/rails#54260 for more info