Skip to content

Chinese Version#27

Open
Haceau-Zoac wants to merge 15 commits into
yujqiao:masterfrom
Haceau-Zoac:master
Open

Chinese Version#27
Haceau-Zoac wants to merge 15 commits into
yujqiao:masterfrom
Haceau-Zoac:master

Conversation

@Haceau-Zoac

Copy link
Copy Markdown

A little contribution :)

@Haceau-Zoac Haceau-Zoac changed the title Chinese README Chinese Version Nov 15, 2020
@yujqiao

yujqiao commented Nov 15, 2020

Copy link
Copy Markdown
Owner

Thanks for your interest!

I took a quick look at your contribution. Good Job.

I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.

And here are some feedbacks:

  • There are some refactoring not related to i18n support. Please place them in a separate PR.

  • It may be better to rename the language option to 'Languages'/'界面语言'

BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.

I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.

@Haceau-Zoac

Copy link
Copy Markdown
Author

Thanks for your interest!

I took a quick look at your contribution. Good Job.

I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files.

And here are some feedbacks:

  • There are some refactoring not related to i18n support. Please place them in a separate PR.
  • It may be better to rename the language option to 'Languages'/'界面语言'

BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README.

I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks.

Yes, I am using a web translator, plus a little bit of my own understanding.

And can the feedbacks be more detailed?

Thanks.

Comment thread sh.exe.stackdump Outdated
Comment thread res/text.zh-TW.txt
Comment thread res/text.zh-CN.txt
@yujqiao

yujqiao commented Jan 5, 2022

Copy link
Copy Markdown
Owner

Sorry for the delay! I've forgotten this stuff 🤡🤡🤡 Your PR looks good and need a little improvement as pointed out.

@yujqiao

yujqiao commented Jan 5, 2022

Copy link
Copy Markdown
Owner

I see the fix of #28 is still in this PR. Can you cherry-pick that and open a separate PR? If you don't have time, I can do that :)

@Haceau-Zoac

Copy link
Copy Markdown
Author

OK

Comment thread src/res.c Outdated
@yujqiao

yujqiao commented Jan 17, 2022

Copy link
Copy Markdown
Owner

behaved weird on my machine (archlinux)

chooseLanguageUi
image

After set to the second option (simplified chinese maybe?)
image

In gameplay
image

Scoreboard
image

@Haceau-Zoac

Copy link
Copy Markdown
Author

behaved weird on my machine (archlinux)

chooseLanguageUi image

After set to the second option (simplified chinese maybe?) image

In gameplay image

Scoreboard image

I merged new commits in this repo but I'm not test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants