🎨 Polish: Improve touch targets for IconButtons - #691
Conversation
Moved explicitly defined small modifier sizes (e.g., Modifier.size(24.dp)) from IconButton wrappers directly to the inner Icon elements. This complies with Android accessibility guidelines which enforce a minimum 48x48dp touch target size for interactive components like IconButtons, while retaining the intended visual size of the icons themselves. Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Moved the
Modifier.size(24.dp)constraints from severalIconButtoncomponents to their innerIconelements acrossMainActivityandChatActivity.🎯 Why
Applying a strict 24.dp size modifier directly to an
IconButtonoverrides Jetpack Compose's default 48x48dp minimum touch target. This makes the buttons overly difficult to tap for users, violating standard Android accessibility guidelines. Moving the constraint to the innerIconkeeps the visual design identical while expanding the interactive bounding box to an accessible size.♿ Accessibility
Resolves implicit accessibility regressions by ensuring all primary interactive action buttons (Refresh, Settings, Stop) possess compliant touch targets.
PR created automatically by Jules for task 16329970278608848277 started by @yuga-hashimoto