🎨 Polish: Improve button feedback and touch targets - #688
Conversation
Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎨 Polish: Improve button feedback and touch targets
💡 What
This PR makes two highly targeted UX improvements:
CircularProgressIndicatoralongside the "Connecting..." text in the main connection button.Modifier.size(24.dp)restrictions on severalIconButtoncomponents acrossMainActivityandChatActivity.🎯 Why
IconButtonto 24dp, the application was violating this guideline, making the buttons harder to reliably tap, especially for users with motor impairments. Removing the modifier allows theIconButtonto size itself appropriately to meet these standards.📸 Before/After
♿ Accessibility
This change directly resolves multiple accessibility touch target violations by allowing standard Compose
IconButtonbehavior to enforce the 48dp minimum touch boundary.🔬 Verification
MainActivity.ktandChatActivity.kt../gradlew app:assembleStandardDebugand ran full unit test suiteapp:testStandardDebugUnitTestwith no regressions.PR created automatically by Jules for task 11883682284153437201 started by @yuga-hashimoto