Skip to content

🎨 Polish: Improve button feedback and touch targets - #688

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
polish-ui-improvements-11883682284153437201
Open

🎨 Polish: Improve button feedback and touch targets#688
yuga-hashimoto wants to merge 1 commit into
mainfrom
polish-ui-improvements-11883682284153437201

Conversation

@yuga-hashimoto

Copy link
Copy Markdown
Owner

🎨 Polish: Improve button feedback and touch targets

💡 What

This PR makes two highly targeted UX improvements:

  1. Loading State Feedback: Added a CircularProgressIndicator alongside the "Connecting..." text in the main connection button.
  2. Accessibility Compliance: Removed hardcoded Modifier.size(24.dp) restrictions on several IconButton components across MainActivity and ChatActivity.

🎯 Why

  • Loading State: Previously, the connection button only changed its text to "Connecting...", which lacked clear, active visual feedback that an operation was in progress. The spinner makes the loading state much more explicit.
  • Accessibility: Android accessibility guidelines strongly recommend a minimum touch target size of 48x48dp for interactive elements. By explicitly sizing the IconButton to 24dp, the application was violating this guideline, making the buttons harder to reliably tap, especially for users with motor impairments. Removing the modifier allows the IconButton to size itself appropriately to meet these standards.

📸 Before/After

  • Before: Connection button just said "Connecting...". Several icon buttons were exactly 24x24dp.
  • After: Connection button shows a white spinner + "Connecting...". Icon buttons now have standard accessible padding while keeping the inner icon at an appropriate visual size.

♿ Accessibility

This change directly resolves multiple accessibility touch target violations by allowing standard Compose IconButton behavior to enforce the 48dp minimum touch boundary.

🔬 Verification

  • Tested locally by modifying MainActivity.kt and ChatActivity.kt.
  • Compiled successfully with ./gradlew app:assembleStandardDebug and ran full unit test suite app:testStandardDebugUnitTest with no regressions.
  • Code review passed.

PR created automatically by Jules for task 11883682284153437201 started by @yuga-hashimoto

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant