Skip to content

fix(chat): make URLs in markdown tables tappable #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuga-hashimoto merged 1 commit into from
Aug 8, 2026
+31 −12
Merged

fix(chat): make URLs in markdown tables tappable #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions app/src/main/java/com/yugahashimoto/andcode/feature/chat/ChatMessageComponents.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.RowScope
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.heightIn
Expand Down Expand Up @@ -277,6 +278,29 @@ private fun InlineText(
}
}

@Composable
private fun RowScope.TableCellText(
text: String,
style: TextStyle,
linkColor: Color,
codeBackground: Color,
) {
val inlines = remember(text) { MarkdownLite.parseInline(text) }
Box(
modifier =
Modifier
.weight(1f)
.padding(end = 8.dp),
) {
InlineText(
inlines = inlines,
style = style,
linkColor = linkColor,
codeBackground = codeBackground,
)
}
}

@Composable
private fun LinkedText(
text: String,
Expand Down Expand Up @@ -447,14 +471,11 @@ private fun MarkdownText(
) {
Row(modifier = Modifier.fillMaxWidth()) {
block.headers.forEach { header ->
Text(
TableCellText(
text = header,
modifier =
Modifier
.weight(1f)
.padding(end = 8.dp),
fontWeight = FontWeight.SemiBold,
style = MaterialTheme.typography.bodyMedium,
style = MaterialTheme.typography.bodyMedium.copy(fontWeight = FontWeight.SemiBold),
linkColor = linkColor,
codeBackground = codeInlineBackground,
)
}
}
Expand All @@ -465,13 +486,11 @@ private fun MarkdownText(
List((block.headers.size - row.size).coerceAtLeast(0)) { "" }
Row(modifier = Modifier.fillMaxWidth()) {
padded.forEach { cell ->
Text(
TableCellText(
text = cell,
modifier =
Modifier
.weight(1f)
.padding(end = 8.dp),
style = MaterialTheme.typography.bodyMedium,
linkColor = linkColor,
codeBackground = codeInlineBackground,
)
}
}
Expand Down
Loading