-
-
Notifications
You must be signed in to change notification settings - Fork 3
fix: keep activity group keys unique when Claude reuses tool call ids #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[bug · high]
詳細シート(findActivityParts)の再解決が、この suffix schemeで壊れます。"activity:toolu_stream:1" は生成時のカウントで決まるため、messages が 1 つ進むたびにオフセットがずれて(1)既に開いているシートが別のグループの内容に置き換わる/(2)該当 id が見つからずシートが急に閉じる、という事象が起こります。これはコメントで主張している「growing run's identity stays stable」と矛盾します。
「連続で登場する index」ではなく「グループが満たす条件そのもの」で id を決める(例: 同一 firstId の連続出現をまとめ、suffix を覆居的な順序としない、または findActivityParts で suffix から n 番目の出現を解決する)方法に変えることを検討してください。少なくとも、_findActivityParts が開いている sheet の id を安定的に再解決できること_を保証する必要があります。