Skip to content

18 rework metrics - #19

Open
charliebtan wants to merge 40 commits into
mainfrom
18-rework-metrics
Open

18 rework metrics#19
charliebtan wants to merge 40 commits into
mainfrom
18-rework-metrics

Conversation

@charliebtan

@charliebtan charliebtan commented Jan 5, 2023

Copy link
Copy Markdown
Collaborator

Main changes:

  • Remove the aggregate metrics
  • Refactor CompletedJourneys (don't need to count per step any more)
  • Fix WaitTime (had bug with off-screen waiting cars, also was dividing by wrong value for average wait time)
  • Add a 'normalised' version of each metric (WaitTime is not truly normalised to [0, 1] but is divided by number of steps)
  • Handles the two metric outputs in Simulator and Emulator

Minor changes:

  • Move metrics.py to main dir - remove metrics dir
  • Add an (i) to inferred params in dataframes (I think its good to be super clear about this - I had it set to infer and didn't know!)

One thing in the issue that I have not done is make the bayesopt loop explicit - I just made the extra outputs work with the built-in loop. Reasons for doing this:

  • Changing to explicit loop changed the output (perhaps would still converge but wanted to avoid changing behaviour)
  • I have seen the built-in loop has a few options which may be sufficient for what I need for report

@charliebtan charliebtan linked an issue Jan 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework Metrics

3 participants