starboard: Replace URL player config macro with tvOS buildflag - #11606
Open
abhijeetk wants to merge 1 commit into
Open
starboard: Replace URL player config macro with tvOS buildflag#11606abhijeetk wants to merge 1 commit into
abhijeetk wants to merge 1 commit into
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Collaborator
Author
|
cc : @Gyuyoung @jkim-julie @rakuco |
abhijeetk
marked this pull request as ready for review
July 30, 2026 06:18
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the generic SB_HAS(PLAYER_WITH_URL) preprocessor macro with the platform-specific BUILDFLAG(IS_IOS_TVOS) across several media and Starboard files, and cleans up the associated configurations. Feedback suggests forward-declaring SbUrlPlayerExtraInfo in sbplayer_interface.h to avoid platform-specific headers in generic interfaces, and points out that including tvOS-specific headers in the generic NPLB test suite violates its platform-agnostic design.
Collaborator
Author
|
This PR implements the changes as per review comment on PR 10698 |
osagie98
reviewed
Jul 30, 2026
SB_HAS_PLAYER_WITH_URL is legacy Cobalt configuration that was only defined for tvOS in configuration_public.h. In the Chromium architecture, BUILDFLAG(IS_IOS_TVOS) is the standard way to gate tvOS-specific code. Replace all SB_HAS(PLAYER_WITH_URL) guards with BUILDFLAG(IS_IOS_TVOS) across sbplayer_bridge, sbplayer_interface, starboard_renderer, and url_player_create_test. Replace the indirect SB_URL_PLAYER_INCLUDE_PATH include with the direct header path. Remove both definitions from starboard/tvos/shared/configuration_public.h. Required-For: youtube#10698 Bug: 512045535
abhijeetk
force-pushed
the
cleanup-sb-has-player-with-url
branch
from
July 30, 2026 19:48
40d52c5 to
bbe2429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SB_HAS_PLAYER_WITH_URL is legacy Cobalt configuration that was only
defined for tvOS in configuration_public.h. In the Chromium
architecture, BUILDFLAG(IS_IOS_TVOS) is the standard way to gate
tvOS-specific code.
Replace all SB_HAS(PLAYER_WITH_URL) guards with BUILDFLAG(IS_IOS_TVOS)
across sbplayer_bridge, sbplayer_interface, starboard_renderer, and
url_player_create_test. Replace the indirect SB_URL_PLAYER_INCLUDE_PATH
include with the direct header path. Remove both definitions from
starboard/tvos/shared/configuration_public.h.
Required-For: #10698
Bug: 512045535