Autoroll from main to staging - #11568
Merged
Merged
Conversation
…sink Refer to original PR: #11549 Update accumulated_written_frames, last_playback_head_position, and playback_head_position to use 64-bit integers in AudioTrackAudioSink. At a 48kHz sampling rate, 32-bit signed integers overflow after approximately 12.4 hours of continuous playback, which can cause incorrect playback head reporting and audio sync issues. Also update GetFramesDurationUs to accept int64_t to maintain type consistency and prevent narrowing. Note that this doesn't resolve all integer size issues across the audio pipeline as the Java AudioTrackBridge is still tracking the playback position using 32 bits integer, which will be resolve in b/539224216. Bug: 539224216 (cherry picked from commit 97d9944)
cobalt-github-releaser-bot
requested review from
briantting,
linxinan-yt and
oxve
July 28, 2026 18:36
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several frame-tracking variables and the GetFramesDurationUs parameter from int to int64_t within AudioTrackAudioSink to prevent potential integer overflow issues. It also updates the .github/AUTOROLL hash. There are no review comments, and I have no feedback to provide.
Refer to original PR: #11550 Add support for a page alignment flag in DecoderBufferAllocator to control OS block allocation alignment. This allows for more granular memory management when using the configurable decommit strategy. Implement a lockless optimization during suspend by checking an atomic flag before acquiring the allocator mutex. This prevents unnecessary blocking of the UI thread when decommit on suspend is not enabled. Additionally, simplify pointer arithmetic in StarboardMemoryAllocator using uint8_t pointers and update H5vcc settings to expose the new alignment configuration bit. Bug: 454441375 (cherry picked from commit 8ac74bd)
briantting
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cherry-pick roll to staging.
Original pull requests: