Skip to content

android: Limit ignored callbacks during flush#11545

Open
jasonzhangxx wants to merge 1 commit into
youtube:mainfrom
jasonzhangxx:dirty-callback
Open

android: Limit ignored callbacks during flush#11545
jasonzhangxx wants to merge 1 commit into
youtube:mainfrom
jasonzhangxx:dirty-callback

Conversation

@jasonzhangxx

@jasonzhangxx jasonzhangxx commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Update MediaCodecBridge to only ignore output buffer callbacks while
the codec is flushing.

Bug: 497004556

@jasonzhangxx
jasonzhangxx requested a review from a team as a code owner July 24, 2026 23:01
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


android: Limit ignored callbacks during flush

Update MediaCodecBridge to only ignore output buffer callbacks while
the codec is flushing. Previously, several callback types including
input buffers and format changes were dropped during this state. This
ensures that the native bridge continues to receive relevant events
that are not strictly related to output data buffers during a flush.

Bug: 497004556

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the mIsFlushing check from several callback methods (onInputBufferAvailable, onOutputFormatChanged, onFrameRendered, and onFirstTunnelFrameReady) in MediaCodecBridge.java, meaning these callbacks will no longer return early when the bridge is flushing. There are no review comments, so I have no feedback to provide.

@jasonzhangxx jasonzhangxx changed the title android: only ignore output callbacks during MediaCodec.flush() android: Limit ignored callbacks during flush Jul 24, 2026
@jasonzhangxx
jasonzhangxx requested a review from borongc July 24, 2026 23:07

@zhongqiliang zhongqiliang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM For ATV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants