Skip to content

[Experiment] Remove FedCM from Cobalt#11535

Open
linxinan-yt wants to merge 4 commits into
youtube:mainfrom
linxinan-yt:fedcmp
Open

[Experiment] Remove FedCM from Cobalt#11535
linxinan-yt wants to merge 4 commits into
youtube:mainfrom
linxinan-yt:fedcmp

Conversation

@linxinan-yt

Copy link
Copy Markdown
Member

Bug: 505811196

@linxinan-yt
linxinan-yt requested a review from a team as a code owner July 24, 2026 03:33
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


cobalt: Disable Privacy Sandbox APIs by default

Disable Privacy Sandbox APIs by setting the default build argument to
false and adding preprocessor guards around associated components.
This change ensures that features like Federated Credential Management
(FedCM), Fenced Frames, and Trust Tokens are excluded from the build.

Excluding these components reduces the Cobalt binary size and removes
APIs that are not required for the current target platforms. Logic
for Credential Management in Blink and Trust Tokens in the network
service is now conditionally compiled based on the build flag.

Bug: 505811196

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@linxinan-yt linxinan-yt changed the title Fedcmp [Experiment] Remove FedCM from Cobalt Jul 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the Privacy Sandbox APIs by setting enable_privacy_sandbox_apis to false in cobalt.gni and conditionally gating related features (such as Fenced Frames, WebID/FedCM, Trust Tokens, and Secure Payment Confirmation) across content/, services/network/, and third_party/blink/ using preprocessor guards and build configuration filters. Feedback is provided regarding an incomplete comment in render_frame_host_impl.cc where a line was accidentally deleted during refactoring.

@@ -10042,8 +10065,8 @@ void RenderFrameHostImpl::DestroyFencedFrame(FencedFrame& fenced_frame) {

fenced_frames_.erase(it);
// An ancestor's network revocation status could've changed as a result of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The second line of the comment was accidentally deleted during refactoring, leaving the sentence incomplete. Please restore the full comment.

  // An ancestor's network revocation status could've changed as a result of
  // this fenced frame being removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant