[Experiment] Remove FedCM from Cobalt#11535
Open
linxinan-yt wants to merge 4 commits into
Open
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the Privacy Sandbox APIs by setting enable_privacy_sandbox_apis to false in cobalt.gni and conditionally gating related features (such as Fenced Frames, WebID/FedCM, Trust Tokens, and Secure Payment Confirmation) across content/, services/network/, and third_party/blink/ using preprocessor guards and build configuration filters. Feedback is provided regarding an incomplete comment in render_frame_host_impl.cc where a line was accidentally deleted during refactoring.
| @@ -10042,8 +10065,8 @@ void RenderFrameHostImpl::DestroyFencedFrame(FencedFrame& fenced_frame) { | |||
|
|
|||
| fenced_frames_.erase(it); | |||
| // An ancestor's network revocation status could've changed as a result of | |||
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 505811196