Skip to content

Autoroll from main to staging#11534

Open
cobalt-github-releaser-bot wants to merge 9 commits into
stagingfrom
autoroll-main-to-staging
Open

Autoroll from main to staging#11534
cobalt-github-releaser-bot wants to merge 9 commits into
stagingfrom
autoroll-main-to-staging

Conversation

Refer to original PR: #11532

Include the utility header in mojo_renderer.cc to provide definitions
for standard library utilities such as std::move. This header was
likely omitted in a previous change, leading to potential compilation
failures in environments where it is not transitively included.

This was removed during the refactor bypass bridge in
#11262.

Issue: 513254071

(cherry picked from commit 603e9c3)
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


media: Add missing utility header to MojoRenderer

Include the utility header in mojo_renderer.cc to ensure that standard
library utilities are available. This prevents potential compilation
errors across various toolchains and build configurations.

Issue: 11532

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the commit hash in the .github/AUTOROLL file and adds a <utility> header include to media/mojo/clients/mojo_renderer.cc. There are no review comments, and I have no feedback to provide.

@datadog-cobalt-youtube

Copy link
Copy Markdown

Tests

⚠️ Warnings

🧪 1 Test failed in 1 job

evergreen_staging | test-results   GitHub Actions

All test failures are known flaky — job may pass on retry.

❄️ Known flaky: Increases/CLOCK_PROCESS_CPUTIME_ID from PosixTimeClockGettimeTests/CpuTimeClock   View in Datadog
../../starboard/nplb/posix_compliance/posix_time_clock_gettime_test.cc:369
Expected: (measured_work_time) &gt;= (minimum_work_time), actual: 70293 vs 75167
CLOCK_PROCESS_CPUTIME_ID time should measure at least  75167 us, of 100223 us elapsed during CPU work.

Not introduced in this PR.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d953e01 | Docs | Give us feedback!

hlwarriner and others added 8 commits July 24, 2026 12:38
Refer to original PR: #11513

Issue: 538114999

(cherry picked from commit 0a4dde4)
Refer to original PR: #11216

aosp: fix musl_statvfs layout

musl's fsblkcnt_t/fsfilcnt_t are 64-bit on all arch, but bionic defines
them
as 32-bit unsigned long on 32-bit targets. On 32-bit arch, the values
can land in wrong offsets in the musl layer.

Fixes the PosixStatvfsTest NPLB tests (SunnyDay, UsageChanges), which
read
misaligned fields:
  posix_sys_statvfs_test.cc:46 f_namemax == 0 (expected > 0)

Bug: 532068409

(cherry picked from commit 2c24ce4)
Refer to original PR: #11537

The struct and the identifier are both renamed to use "Starboard"
instead of "Cobalt". This is our preference since b/150221489.

This would normally be a breaking change but it's ok since this is a
brand new extension that is not yet on any production devices.

Issue: 528362453

(cherry picked from commit 1bda4c2)
Refer to original PR: #11339

bionic's if_indextoname sets ENODEV for a nonexistent interface index,
while POSIX expects ENXIO.

Bug: 532068409

(cherry picked from commit 739c295)
Refer to original PR: #11460

Android starts the process with the working directory at "/"
(read-only), so nplb tests that create files or symlinks with relative
paths (such as
PosixSymlinkTest.SuccessfulCreation/CanCreateDanglingLink, and other
PosixLinkTests) will fail.

Fixes the following issues in tests:
  posix_symlink_test.cc:52 symlink() == -1 (Read-only file system)

Bug: 532068409

(cherry picked from commit 2c48807)
Refer to original PR: #11432

Disable Privacy Sandbox components in the Cobalt build configuration
to reduce the final binary size. This flag is maintained as a
temporary measure until the relevant components are completely
removed in a future milestone rebase.

Before:
$ ls -l out/android-arm_gold/apks/Cobalt.apk
-rw------- 1 foo primarygroup 86939150 Jul 20 07:00
out/android-arm_gold/apks/Cobalt.apk

After:
$ ls -l out/android-arm_gold/apks/Cobalt.apk
-rw------- 1 foo primarygroup 85510521 Jul 20 03:46
out/android-arm_gold/apks/Cobalt.apk

In total, Privacy Sandbox removal saved 1.36MB for APK size.

To keep the CI green, also disabled privacy sandbox features in
web_tests.

Bug: 505811196

(cherry picked from commit 1986dff)
Refer to original PR: #11547

Packaging scripts for all platforms belong in cobalt/build. Create a
directory for tvOS in there.

Bug: 538751678

Co-authored-by: Xinan Lin <65635777+linxinan-yt@users.noreply.github.com>

(cherry picked from commit 7fdffec)
Refer to original PR: #11449

GN's complete_static_lib does not merge Rust .rlib archives into the C++
static library. This script takes the .rlib artifacts and merges them
into cobalt.a. This is a one-off use-case just for tvOS and the cobalt.a
snapshot pipeline for integration into the blaze production app. Below
is an example error of missing symbols. See bug for additional details.

```
"_blink$cxxbridge1$crash_in_rust", referenced from:
    blink::crash_in_rust() in ...(lib.rs.o)
"_blink$cxxbridge1$crash_in_rust_with_overflow", referenced from:
    blink::crash_in_rust_with_overflow() in ...(lib.rs.o)
"_blink$cxxbridge1$reenter_rust", referenced from:
    blink::reenter_rust() in ...(lib.rs.o)

"_cxxbridge1$box$fontations_ffi$BridgeBitmapGlyph$alloc", referenced from:
    rust::cxxbridge1::Box<fontations_ffi::BridgeBitmapGlyph>::allocation::alloc() in ...(ffi.rs.o)
"_cxxbridge1$box$fontations_ffi$BridgeFontRef$alloc", referenced from:
    rust::cxxbridge1::Box<fontations_ffi::BridgeFontRef>::allocation::alloc() in ...(ffi.rs.o)
"_cxxbridge1$box$fontations_ffi$BridgeHintingInstance$alloc", referenced from:
    rust::cxxbridge1::Box<fontations_ffi::BridgeHintingInstance>::allocation::alloc() in ...(ffi.rs.o)

"_cxxbridge1$exception", referenced from:
    rust::cxxbridge1::detail::Fail::operator()(char const*) in ...(cxx.o)

"_cxxbridge1$rust_vec$bool$capacity"
"_cxxbridge1$rust_vec$bool$data"
"_cxxbridge1$rust_vec$bool$drop"
"_cxxbridge1$rust_vec$bool$len"
"_cxxbridge1$rust_vec$bool$new"
... (hundreds more _cxxbridge1$rust_vec$... symbols for bool, char, f32, f64, i16, i32, i64, i8, isize, str, string, u16, etc.)
```

Bug: 537031363

(cherry picked from commit 35c33b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants