Skip to content

cobalt: Remove unused codes under cobalt/shell - #11530

Open
kjyoun wants to merge 2 commits into
youtube:mainfrom
kjyoun:remove-unused-codes-cobalt
Open

cobalt: Remove unused codes under cobalt/shell#11530
kjyoun wants to merge 2 commits into
youtube:mainfrom
kjyoun:remove-unused-codes-cobalt

Conversation

@kjyoun

@kjyoun kjyoun commented Jul 24, 2026

Copy link
Copy Markdown
Member

Clean up the Android shell implementation by removing various unused
methods, constants, and imports across ContentViewRenderView, Shell,
and ShellManager classes. This dead code is no longer necessary for
the Cobalt Android shell's functionality.

go/deadcode

Issue: 413418478

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


android: Remove unused code from shell

Clean up the Android shell implementation by removing various unused
methods, constants, and imports across ContentViewRenderView, Shell,
and ShellManager classes. This dead code is no longer necessary for
the Cobalt Android shell's functionality.

Bug: 413418478

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@kjyoun kjyoun changed the title cobalt: Remove unused codes cobalt: Remove unused codes under cobalt/shell Jul 24, 2026
@kjyoun
kjyoun marked this pull request as ready for review July 24, 2026 15:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the codebase by removing several unused methods, constants, and imports across ContentViewRenderView.java, Shell.java, and ShellManager.java. Specifically, it removes unused helper methods like setSurfaceViewBackgroundColor, isInitialized, isDestroyed, isLoading, getWindow, and an overloaded launchShell method, along with their associated unused imports and constants. There are no review comments, so I have no additional feedback to provide.

@kjyoun
kjyoun requested review from borongc and zhongqiliang July 24, 2026 15:33
}
}

/**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the plan for rebase Cobalt shell, these are mostly the functions from upstream Content shell, if we remove them, it will increase the difficulty while rebasing Cobalt shell.

We should clearly check with browser team to see if there is any plan to rebase Cobalt shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants